Add the Move Parallel Tool #2004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpechacek
force-pushed
the
issue-650-move-parallel-tool
branch
from
41eaeb1 to
33fd032
Compare
Member
|
One small observation: although the Move Parallel tool can only be activated once an appropriate object has been selected, it stays activated once the object becomes unavailable (e.g., has been moved to another map part, has been deleted or it's underlying symbol has been deleted). That's not a big issue since you can deactivate the tool by choosing another tool. |
lpechacek
force-pushed
the
issue-650-move-parallel-tool
branch
from
33fd032 to
97c48bd
Compare
Member
Author
Thanks for testing! I've aligned the new tool behavior with the other tools on this front. |
dg0yt
reviewed
Dec 20, 2021
Member
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Thank you for the PR. I'm sorry that I couldn't test the feature yet.
The tangent vector is essential for the move parallel tool where we want to calculate the distance of the cursor from the tangent line touching the path in question. Please note that we are generating a "pseudo tangent" for corners and line ends to enable sensible behavior during mouse drag events.
The tool moves lines and area boundaries to create a larger or a smaller shape parallel to the original object. The tool reuses LineSymbol::shiftCoordinates() which currently does not handle shape degeneration. I.e., curve turns do not shrink into points but rather form a "negative" shape that is a mathematically exact image of the original curve but usually is not what the user expects. Closes OpenOrienteeringGH-650
lpechacek
force-pushed
the
issue-650-move-parallel-tool
branch
from
97c48bd to
be4003f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the Move Parallel tool does not behave perfectly in every situation (shape distortion on small curves and bevel-join-like corner cuts on sharp corners), it works fine on "sensible" shapes. This is still an improvement over the current state where the best approximation of this tool is the Line Edit tool or tricks with helper double lines.